diff options
author | Michal Hocko <mhocko@suse.com> | 2019-02-01 14:21:12 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-02-01 15:46:23 -0800 |
commit | e3df4c6e4836ce93cd5cf92d9cbdeaf4439a0241 (patch) | |
tree | 2f6cc7bb49b820e82c6aae5c2e70429caeeb4b8c /mm/zbud.c | |
parent | 6376360ecbe525a9c17b3d081dfd88ba3e4ed65b (diff) | |
download | linux-e3df4c6e4836ce93cd5cf92d9cbdeaf4439a0241.tar.gz linux-e3df4c6e4836ce93cd5cf92d9cbdeaf4439a0241.tar.bz2 linux-e3df4c6e4836ce93cd5cf92d9cbdeaf4439a0241.zip |
mm, memory_hotplug: __offline_pages fix wrong locking
Jan has noticed that we do double unlock on some failure paths when
offlining a page range. This is indeed the case when
test_pages_in_a_zone respp. start_isolate_page_range fail. This was an
omission when forward porting the debugging patch from an older kernel.
Fix the issue by dropping mem_hotplug_done from the failure condition
and keeping the single unlock in the catch all failure path.
Link: http://lkml.kernel.org/r/20190115120307.22768-1-mhocko@kernel.org
Fixes: 7960509329c2 ("mm, memory_hotplug: print reason for the offlining failure")
Signed-off-by: Michal Hocko <mhocko@suse.com>
Reported-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Tested-by: Jan Kara <jack@suse.cz>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm/zbud.c')
0 files changed, 0 insertions, 0 deletions