diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-07-08 13:37:40 +0200 |
|---|---|---|
| committer | Pekka Enberg <penberg@kernel.org> | 2012-07-09 12:04:34 +0300 |
| commit | 068ce415bea9e2b96bde76dc1bf6e672a89903ee (patch) | |
| tree | 88d497604903bdb26bf0b0f7a1672a724218360a /mm | |
| parent | 4b57ad939263935e4e3aec4d74a11dd02a3421e4 (diff) | |
| download | linux-068ce415bea9e2b96bde76dc1bf6e672a89903ee.tar.gz linux-068ce415bea9e2b96bde76dc1bf6e672a89903ee.tar.bz2 linux-068ce415bea9e2b96bde76dc1bf6e672a89903ee.zip | |
slub: remove invalid reference to list iterator variable
If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure. Thus this value should not be used after
the end of the iterator. The patch replaces s->name by al->name, which is
referenced nearby.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/).
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Diffstat (limited to 'mm')
| -rw-r--r-- | mm/slub.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/mm/slub.c b/mm/slub.c index f96d8bcec54f..79fe9c6b93cf 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -5405,7 +5405,7 @@ static int __init slab_sysfs_init(void) err = sysfs_slab_alias(al->s, al->name); if (err) printk(KERN_ERR "SLUB: Unable to add boot slab alias" - " %s to sysfs\n", s->name); + " %s to sysfs\n", al->name); kfree(al); } |