diff options
author | Francesco Ruggeri <fruggeri@aristanetworks.com> | 2012-09-13 15:03:37 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-09-17 10:32:03 -0700 |
commit | 6bf6104573482570f7103d3e5ddf9574db43a363 (patch) | |
tree | 4aa02983bfffbe0d623c0163822354b48693eca0 /mm | |
parent | 5698bd757d55b1bb87edd1a9744ab09c142abfc2 (diff) | |
download | linux-6bf6104573482570f7103d3e5ddf9574db43a363.tar.gz linux-6bf6104573482570f7103d3e5ddf9574db43a363.tar.bz2 linux-6bf6104573482570f7103d3e5ddf9574db43a363.zip |
fs/proc: fix potential unregister_sysctl_table hang
The unregister_sysctl_table() function hangs if all references to its
ctl_table_header structure are not dropped.
This can happen sometimes because of a leak in proc_sys_lookup():
proc_sys_lookup() gets a reference to the table via lookup_entry(), but
it does not release it when a subsequent call to sysctl_follow_link()
fails.
This patch fixes this leak by making sure the reference is always
dropped on return.
See also commit 076c3eed2c31 ("sysctl: Rewrite proc_sys_lookup
introducing find_entry and lookup_entry") which reorganized this code in
3.4.
Tested in Linux 3.4.4.
Signed-off-by: Francesco Ruggeri <fruggeri@aristanetworks.com>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions