diff options
| author | Padmanabh Ratnakar <padmanabh.ratnakar@avagotech.com> | 2015-11-03 20:25:59 +0530 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-11-03 11:29:56 -0500 |
| commit | 74f2d19caff885bc656e9acf2a6e727b66ab0ed1 (patch) | |
| tree | 0d056329707ce290142860ca6095f08e788f9a34 /net/8021q | |
| parent | 754107e34165373b3696620cef344227b10eaa99 (diff) | |
| download | linux-74f2d19caff885bc656e9acf2a6e727b66ab0ed1.tar.gz linux-74f2d19caff885bc656e9acf2a6e727b66ab0ed1.tar.bz2 linux-74f2d19caff885bc656e9acf2a6e727b66ab0ed1.zip | |
vlan: Invoke driver vlan hooks only if device is present
NIC drivers mark device as detached during error recovery.
It expects no manangement hooks to be invoked in this state.
Invoke driver vlan hooks only if device is present.
Signed-off-by: Padmanabh Ratnakar <padmanabh.ratnakar@avagotech.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
| -rw-r--r-- | net/8021q/vlan_core.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c index 61bf2a06e85d..496b27588493 100644 --- a/net/8021q/vlan_core.c +++ b/net/8021q/vlan_core.c @@ -206,7 +206,10 @@ static int __vlan_vid_add(struct vlan_info *vlan_info, __be16 proto, u16 vid, return -ENOMEM; if (vlan_hw_filter_capable(dev, vid_info)) { - err = ops->ndo_vlan_rx_add_vid(dev, proto, vid); + if (netif_device_present(dev)) + err = ops->ndo_vlan_rx_add_vid(dev, proto, vid); + else + err = -ENODEV; if (err) { kfree(vid_info); return err; @@ -264,7 +267,10 @@ static void __vlan_vid_del(struct vlan_info *vlan_info, int err; if (vlan_hw_filter_capable(dev, vid_info)) { - err = ops->ndo_vlan_rx_kill_vid(dev, proto, vid); + if (netif_device_present(dev)) + err = ops->ndo_vlan_rx_kill_vid(dev, proto, vid); + else + err = -ENODEV; if (err) { pr_warn("failed to kill vid %04x/%d for device %s\n", proto, vid, dev->name); |