diff options
author | Vlad Yasevich <vyasevich@gmail.com> | 2015-11-16 15:43:44 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-11-17 14:38:35 -0500 |
commit | a6e18ff111701b4ff6947605bfbe9594ec42a6e8 (patch) | |
tree | b6905bc0ea1eadc2a237dcefe3d88f14fd1e00e0 /net/8021q | |
parent | 6c606fa32c4272894248c1abbc15257fc04250be (diff) | |
download | linux-a6e18ff111701b4ff6947605bfbe9594ec42a6e8.tar.gz linux-a6e18ff111701b4ff6947605bfbe9594ec42a6e8.tar.bz2 linux-a6e18ff111701b4ff6947605bfbe9594ec42a6e8.zip |
vlan: Fix untag operations of stacked vlans with REORDER_HEADER off
When we have multiple stacked vlan devices all of which have
turned off REORDER_HEADER flag, the untag operation does not
locate the ethernet addresses correctly for nested vlans.
The reason is that in case of REORDER_HEADER flag being off,
the outer vlan headers are put back and the mac_len is adjusted
to account for the presense of the header. Then, the subsequent
untag operation, for the next level vlan, always use VLAN_ETH_HLEN
to locate the begining of the ethernet header and that ends up
being a multiple of 4 bytes short of the actuall beginning
of the mac header (the multiple depending on the how many vlan
encapsulations ethere are).
As a reslult, if there are multiple levles of vlan devices
with REODER_HEADER being off, the recevied packets end up
being dropped.
To solve this, we use skb->mac_len as the offset. The value
is always set on receive path and starts out as a ETH_HLEN.
The value is also updated when the vlan header manupations occur
so we know it will be correct.
Signed-off-by: Vladislav Yasevich <vyasevic@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
0 files changed, 0 insertions, 0 deletions