diff options
| author | Andrey Utkin <andrey.krieger.utkin@gmail.com> | 2014-07-07 23:22:50 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-07-08 19:39:43 -0700 |
| commit | 36beddc272c111689f3042bf3d10a64d8a805f93 (patch) | |
| tree | 22af97ed421e6e98645259a4f39b5787e909915c /net/appletalk | |
| parent | e0056593b61253f1a8a9941dacda22e73b963cdc (diff) | |
| download | linux-36beddc272c111689f3042bf3d10a64d8a805f93.tar.gz linux-36beddc272c111689f3042bf3d10a64d8a805f93.tar.bz2 linux-36beddc272c111689f3042bf3d10a64d8a805f93.zip | |
appletalk: Fix socket referencing in skb
Setting just skb->sk without taking its reference and setting a
destructor is invalid. However, in the places where this was done, skb
is used in a way not requiring skb->sk setting. So dropping the setting
of skb->sk.
Thanks to Eric Dumazet <eric.dumazet@gmail.com> for correct solution.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=79441
Reported-by: Ed Martin <edman007@edman007.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/appletalk')
| -rw-r--r-- | net/appletalk/ddp.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 01a1082e02b3..bfcf6be1d665 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1489,8 +1489,6 @@ static int atalk_rcv(struct sk_buff *skb, struct net_device *dev, goto drop; /* Queue packet (standard) */ - skb->sk = sock; - if (sock_queue_rcv_skb(sock, skb) < 0) goto drop; @@ -1644,7 +1642,6 @@ static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr if (!skb) goto out; - skb->sk = sk; skb_reserve(skb, ddp_dl->header_length); skb_reserve(skb, dev->hard_header_len); skb->dev = dev; |