summaryrefslogtreecommitdiffstats
path: root/net/atm
diff options
context:
space:
mode:
authorJorge Boncompte [DTI2] <jorge@dti2.net>2011-11-21 10:25:54 +0000
committerDavid S. Miller <davem@davemloft.net>2011-11-22 16:15:22 -0500
commitfe685b80469996149ca28c74062f72b5879c1607 (patch)
tree7885ea4abcda7a2cc64274a51a72ba61e2c81487 /net/atm
parente348c5e7de4a759a94eed4d0303ba81a4939f8b9 (diff)
downloadlinux-fe685b80469996149ca28c74062f72b5879c1607.tar.gz
linux-fe685b80469996149ca28c74062f72b5879c1607.tar.bz2
linux-fe685b80469996149ca28c74062f72b5879c1607.zip
atm: br2684: Do not move counters backwards
This snippet has caused several bugs in the past, and I don't see the point on substracting the skb len from netdev stats. Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/atm')
-rw-r--r--net/atm/br2684.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index d07223c834af..81cf33b1527d 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
skb_queue_splice_init(rq, &queue);
spin_unlock_irqrestore(&rq->lock, flags);
- skb_queue_walk_safe(&queue, skb, tmp) {
- struct net_device *dev;
-
+ skb_queue_walk_safe(&queue, skb, tmp)
br2684_push(atmvcc, skb);
- dev = skb->dev;
-
- dev->stats.rx_bytes -= skb->len;
- dev->stats.rx_packets--;
- }
/* initialize netdev carrier state */
if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)