diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2005-12-20 15:19:51 -0800 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2006-01-03 13:11:01 -0800 |
| commit | 4433f420e57afae0ab308b1e2b979f09c86bc115 (patch) | |
| tree | 3481cdce9a8ba28ba8ad26d0ed49151c1d08f4b7 /net/bridge/br_notify.c | |
| parent | 4505a3ef720845b5db3ddb440de13cd4800fd508 (diff) | |
| download | linux-4433f420e57afae0ab308b1e2b979f09c86bc115.tar.gz linux-4433f420e57afae0ab308b1e2b979f09c86bc115.tar.bz2 linux-4433f420e57afae0ab308b1e2b979f09c86bc115.zip | |
[BRIDGE]: handle speed detection after carrier changes
Speed of a interface may not be available until carrier
is detected in the case of autonegotiation. To get the correct value
we need to recheck speed after carrier event. But the check needs to
be done in a context that is similar to normal ethtool interface (can sleep).
Also, delay check for 1ms to try avoid any carrier bounce transitions.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_notify.c')
| -rw-r--r-- | net/bridge/br_notify.c | 14 |
1 files changed, 3 insertions, 11 deletions
diff --git a/net/bridge/br_notify.c b/net/bridge/br_notify.c index 917311c6828b..a43a9c1d50d7 100644 --- a/net/bridge/br_notify.c +++ b/net/bridge/br_notify.c @@ -52,17 +52,9 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v br_stp_recalculate_bridge_id(br); break; - case NETDEV_CHANGE: /* device is up but carrier changed */ - if (!(br->dev->flags & IFF_UP)) - break; - - if (netif_carrier_ok(dev)) { - if (p->state == BR_STATE_DISABLED) - br_stp_enable_port(p); - } else { - if (p->state != BR_STATE_DISABLED) - br_stp_disable_port(p); - } + case NETDEV_CHANGE: + if (br->dev->flags & IFF_UP) + schedule_delayed_work(&p->carrier_check, BR_PORT_DEBOUNCE); break; case NETDEV_FEAT_CHANGE: |