diff options
| author | Nikolay Aleksandrov <nikolay@nvidia.com> | 2021-09-03 12:34:15 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-03 13:43:19 +0100 |
| commit | ddd0d5293810c1882e2a96f8cce1678823b1dd38 (patch) | |
| tree | 8563288bda78a32c668b9a5980fa9fcd2607c7c4 /net/bridge | |
| parent | f1181e39d6ac13c0879b3766138aaa384fe62a55 (diff) | |
| download | linux-ddd0d5293810c1882e2a96f8cce1678823b1dd38.tar.gz linux-ddd0d5293810c1882e2a96f8cce1678823b1dd38.tar.bz2 linux-ddd0d5293810c1882e2a96f8cce1678823b1dd38.zip | |
net: bridge: mcast: fix vlan port router deadlock
Before vlan/port mcast router support was added
br_multicast_set_port_router was used only with bh already disabled due
to the bridge port lock, but that is no longer the case and when it is
called to configure a vlan/port mcast router we can deadlock with the
timer, so always disable bh to make sure it can be called from contexts
with both enabled and disabled bh.
Fixes: 2796d846d74a ("net: bridge: vlan: convert mcast router global option to per-vlan entry")
Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
| -rw-r--r-- | net/bridge/br_multicast.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 9231617a16e4..3523c8c7068f 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -4255,7 +4255,7 @@ int br_multicast_set_port_router(struct net_bridge_mcast_port *pmctx, bool del = false; brmctx = br_multicast_port_ctx_get_global(pmctx); - spin_lock(&brmctx->br->multicast_lock); + spin_lock_bh(&brmctx->br->multicast_lock); if (pmctx->multicast_router == val) { /* Refresh the temp router port timer */ if (pmctx->multicast_router == MDB_RTR_TYPE_TEMP) { @@ -4305,7 +4305,7 @@ int br_multicast_set_port_router(struct net_bridge_mcast_port *pmctx, } err = 0; unlock: - spin_unlock(&brmctx->br->multicast_lock); + spin_unlock_bh(&brmctx->br->multicast_lock); return err; } |