diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-11-09 11:46:33 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-11-09 12:17:16 -0800 |
| commit | 332dd96f7ac15e937088fe11f15cfe0210e8edd1 (patch) | |
| tree | 8efe236b18c0abacee96f9ed5fa6cfd396cdedcf /net/core/dst.c | |
| parent | 88f8a5e3e7defccd3925cabb1ee4d3994e5cdb52 (diff) | |
| download | linux-332dd96f7ac15e937088fe11f15cfe0210e8edd1.tar.gz linux-332dd96f7ac15e937088fe11f15cfe0210e8edd1.tar.bz2 linux-332dd96f7ac15e937088fe11f15cfe0210e8edd1.zip | |
net/dst: dst_dev_event() called after other notifiers
Followup of commit ef885afbf8a37689 (net: use rcu_barrier() in
rollback_registered_many)
dst_dev_event() scans a garbage dst list that might be feeded by various
network notifiers at device dismantle time.
Its important to call dst_dev_event() after other notifiers, or we might
enter the infamous msleep(250) in netdev_wait_allrefs(), and wait one
second before calling again call_netdevice_notifiers(NETDEV_UNREGISTER,
dev) to properly remove last device references.
Use priority -10 to let dst_dev_notifier be called after other network
notifiers (they have the default 0 priority)
Reported-by: Ben Greear <greearb@candelatech.com>
Reported-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reported-by: Octavian Purdila <opurdila@ixiacom.com>
Reported-by: Benjamin LaHaise <bcrl@kvack.org>
Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dst.c')
| -rw-r--r-- | net/core/dst.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/dst.c b/net/core/dst.c index 8abe628b79f1..b99c7c7ffce2 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -370,6 +370,7 @@ static int dst_dev_event(struct notifier_block *this, unsigned long event, static struct notifier_block dst_dev_notifier = { .notifier_call = dst_dev_event, + .priority = -10, /* must be called after other network notifiers */ }; void __init dst_init(void) |