summaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2017-11-06 15:04:54 +0000
committerDavid S. Miller <davem@davemloft.net>2017-11-08 13:46:25 +0900
commit03ac738d5cf2f97ffa1209f6fd5d4bc211a933de (patch)
treec927cc489307ccecf62d63fc083300893dea4542 /net/core
parentac71a1f94418b9b83c9bf04f76954570d88c9590 (diff)
downloadlinux-03ac738d5cf2f97ffa1209f6fd5d4bc211a933de.tar.gz
linux-03ac738d5cf2f97ffa1209f6fd5d4bc211a933de.tar.bz2
linux-03ac738d5cf2f97ffa1209f6fd5d4bc211a933de.zip
rtnetlink: fix missing size for IFLA_IF_NETNSID
The size for IFLA_IF_NETNSID is missing from the size calculation because the proceeding semicolon was not removed. Fix this by removing the semicolon. Detected by CoverityScan, CID#1461135 ("Structurally dead code") Fixes: 79e1ad148c84 ("rtnetlink: use netnsid to query interface") Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Jiri Benc <jbenc@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/rtnetlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index dc5ad84ac096..dabba2a91fc8 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -920,7 +920,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
+ rtnl_xdp_size() /* IFLA_XDP */
+ nla_total_size(4) /* IFLA_EVENT */
+ nla_total_size(4) /* IFLA_NEW_NETNSID */
- + nla_total_size(1); /* IFLA_PROTO_DOWN */
+ + nla_total_size(1) /* IFLA_PROTO_DOWN */
+ nla_total_size(4) /* IFLA_IF_NETNSID */
+ 0;
}