diff options
author | Sabrina Dubroca <sd@queasysnail.net> | 2015-07-24 18:19:25 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-07-27 01:06:53 -0700 |
commit | dfbafc995304ebb9a9b03f65083e6e9cea143b20 (patch) | |
tree | db3c54339548ef9e9e9b053e3c5d2f77c1dc560f /net/dccp | |
parent | 3d3af8859284f982ad62980b3787f05259f1dd10 (diff) | |
download | linux-dfbafc995304ebb9a9b03f65083e6e9cea143b20.tar.gz linux-dfbafc995304ebb9a9b03f65083e6e9cea143b20.tar.bz2 linux-dfbafc995304ebb9a9b03f65083e6e9cea143b20.zip |
tcp: fix recv with flags MSG_WAITALL | MSG_PEEK
Currently, tcp_recvmsg enters a busy loop in sk_wait_data if called
with flags = MSG_WAITALL | MSG_PEEK.
sk_wait_data waits for sk_receive_queue not empty, but in this case,
the receive queue is not empty, but does not contain any skb that we
can use.
Add a "last skb seen on receive queue" argument to sk_wait_data, so
that it sleeps until the receive queue has new skbs.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=99461
Link: https://sourceware.org/bugzilla/show_bug.cgi?id=18493
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1205258
Reported-by: Enrico Scholz <rh-bugzilla@ensc.de>
Reported-by: Dan Searle <dan@censornet.com>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp')
-rw-r--r-- | net/dccp/proto.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 52a94016526d..b5cf13a28009 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c @@ -886,7 +886,7 @@ verify_sock_status: break; } - sk_wait_data(sk, &timeo); + sk_wait_data(sk, &timeo, NULL); continue; found_ok_skb: if (len > skb->len) |