diff options
| author | Florian Fainelli <f.fainelli@gmail.com> | 2015-08-08 12:58:57 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-08-12 14:29:50 -0700 |
| commit | 211c504a444710b1d8ce3431ac19f2578602ca27 (patch) | |
| tree | 450435fc4df735cec29228780694d7e3bb98a726 /net/dsa | |
| parent | 28eaad7504d2ca1c833299ebf5148671638732f9 (diff) | |
| download | linux-211c504a444710b1d8ce3431ac19f2578602ca27.tar.gz linux-211c504a444710b1d8ce3431ac19f2578602ca27.tar.bz2 linux-211c504a444710b1d8ce3431ac19f2578602ca27.zip | |
net: dsa: Do not override PHY interface if already configured
In case we need to divert reads/writes using the slave MII bus, we may have
already fetched a valid PHY interface property from Device Tree, and that
mode is used by the PHY driver to make configuration decisions.
If we could not fetch the "phy-mode" property, we will assign p->phy_interface
to PHY_INTERFACE_MODE_NA, such that we can actually check for that condition as
to whether or not we should override the interface value.
Fixes: 19334920eaf7 ("net: dsa: Set valid phy interface type")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
| -rw-r--r-- | net/dsa/slave.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 0917123790ea..35c47ddd04f0 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -756,7 +756,8 @@ static int dsa_slave_phy_connect(struct dsa_slave_priv *p, return -ENODEV; /* Use already configured phy mode */ - p->phy_interface = p->phy->interface; + if (p->phy_interface == PHY_INTERFACE_MODE_NA) + p->phy_interface = p->phy->interface; phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link, p->phy_interface); |