diff options
| author | Cong Wang <xiyou.wangcong@gmail.com> | 2019-07-03 17:21:13 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-07-05 15:22:27 -0700 |
| commit | b9a1e627405d68d475a3c1f35e685ccfb5bbe668 (patch) | |
| tree | 4130c796a3b6477e01126514e08f9cb2fc91f4b6 /net/hsr/hsr_device.h | |
| parent | 619afef01f74f3572b5e9a266c1230dc83761eec (diff) | |
| download | linux-b9a1e627405d68d475a3c1f35e685ccfb5bbe668.tar.gz linux-b9a1e627405d68d475a3c1f35e685ccfb5bbe668.tar.bz2 linux-b9a1e627405d68d475a3c1f35e685ccfb5bbe668.zip | |
hsr: implement dellink to clean up resources
hsr_link_ops implements ->newlink() but not ->dellink(),
which leads that resources not released after removing the device,
particularly the entries in self_node_db and node_db.
So add ->dellink() implementation to replace the priv_destructor.
This also makes the code slightly easier to understand.
Reported-by: syzbot+c6167ec3de7def23d1e8@syzkaller.appspotmail.com
Cc: Arvid Brodin <arvid.brodin@alten.se>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/hsr/hsr_device.h')
| -rw-r--r-- | net/hsr/hsr_device.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/hsr/hsr_device.h b/net/hsr/hsr_device.h index 6d7759c4f5f9..d0fa6b0696d2 100644 --- a/net/hsr/hsr_device.h +++ b/net/hsr/hsr_device.h @@ -14,6 +14,7 @@ void hsr_dev_setup(struct net_device *dev); int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2], unsigned char multicast_spec, u8 protocol_version); +void hsr_dev_destroy(struct net_device *hsr_dev); void hsr_check_carrier_and_operstate(struct hsr_priv *hsr); bool is_hsr_master(struct net_device *dev); int hsr_get_max_mtu(struct hsr_priv *hsr); |