diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-11-12 09:33:09 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-11-13 20:46:58 -0800 |
| commit | 2c1409a0a2b88585ec0c03f1de0aafa178c56313 (patch) | |
| tree | e9fc25badfb716e5368079535f548cc8e4b5576a /net/ipv4/route.c | |
| parent | 234b27c3fd58fc0e15c04dd0fbf4337fac9c2a06 (diff) | |
| download | linux-2c1409a0a2b88585ec0c03f1de0aafa178c56313.tar.gz linux-2c1409a0a2b88585ec0c03f1de0aafa178c56313.tar.bz2 linux-2c1409a0a2b88585ec0c03f1de0aafa178c56313.zip | |
inetpeer: Optimize inet_getid()
While investigating for network latencies, I found inet_getid() was a
contention point for some workloads, as inet_peer_idlock is shared
by all inet_getid() users regardless of peers.
One way to fix this is to make ip_id_count an atomic_t instead
of __u16, and use atomic_add_return().
In order to keep sizeof(struct inet_peer) = 64 on 64bit arches
tcp_ts_stamp is also converted to __u32 instead of "unsigned long".
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/route.c')
| -rw-r--r-- | net/ipv4/route.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index ff258b57680b..4284ceef7945 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2852,7 +2852,7 @@ static int rt_fill_info(struct net *net, error = rt->u.dst.error; expires = rt->u.dst.expires ? rt->u.dst.expires - jiffies : 0; if (rt->peer) { - id = rt->peer->ip_id_count; + id = atomic_read(&rt->peer->ip_id_count) & 0xffff; if (rt->peer->tcp_ts_stamp) { ts = rt->peer->tcp_ts; tsage = get_seconds() - rt->peer->tcp_ts_stamp; |