diff options
| author | Eric Dumazet <edumazet@google.com> | 2019-11-05 14:11:53 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-11-06 16:14:48 -0800 |
| commit | 288efe8606b62d0753ba6722b36ef241877251fd (patch) | |
| tree | 37cbacf02e504fafe20062ae25909a4ecfc4c807 /net/ipv4/tcp.c | |
| parent | 7976a11b30929871a4c84c3c406d7681a3dbcc10 (diff) | |
| download | linux-288efe8606b62d0753ba6722b36ef241877251fd.tar.gz linux-288efe8606b62d0753ba6722b36ef241877251fd.tar.bz2 linux-288efe8606b62d0753ba6722b36ef241877251fd.zip | |
net: annotate lockless accesses to sk->sk_ack_backlog
sk->sk_ack_backlog can be read without any lock being held.
We need to use READ_ONCE()/WRITE_ONCE() to avoid load/store tearing
and/or potential KCSAN warnings.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp.c')
| -rw-r--r-- | net/ipv4/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 1dd25189d83f..68375f7ffdce 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -3225,7 +3225,7 @@ void tcp_get_info(struct sock *sk, struct tcp_info *info) * tcpi_unacked -> Number of children ready for accept() * tcpi_sacked -> max backlog */ - info->tcpi_unacked = sk->sk_ack_backlog; + info->tcpi_unacked = READ_ONCE(sk->sk_ack_backlog); info->tcpi_sacked = sk->sk_max_ack_backlog; return; } |