diff options
| author | Yuchung Cheng <ycheng@google.com> | 2013-10-12 10:16:27 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-10-17 15:41:02 -0400 |
| commit | 031afe4990a7c9dbff41a3a742c44d3e740ea0a1 (patch) | |
| tree | faf4f3bcc4b2e99d57f18990da44b97d0795939f /net/ipv4/tcp_input.c | |
| parent | 09b69024d97356fb660d1162e172ed4f1be7ceae (diff) | |
| download | linux-031afe4990a7c9dbff41a3a742c44d3e740ea0a1.tar.gz linux-031afe4990a7c9dbff41a3a742c44d3e740ea0a1.tar.bz2 linux-031afe4990a7c9dbff41a3a742c44d3e740ea0a1.zip | |
tcp: fix incorrect ca_state in tail loss probe
On receiving an ACK that covers the loss probe sequence, TLP
immediately sets the congestion state to Open, even though some packets
are not recovered and retransmisssion are on the way. The later ACks
may trigger a WARN_ON check in step D of tcp_fastretrans_alert(), e.g.,
https://bugzilla.redhat.com/show_bug.cgi?id=989251
The fix is to follow the similar procedure in recovery by calling
tcp_try_keep_open(). The sender switches to Open state if no packets
are retransmissted. Otherwise it goes to Disorder and let subsequent
ACKs move the state to Recovery or Open.
Reported-By: Michael Sterrett <michael@sterretts.net>
Tested-By: Dormando <dormando@rydia.net>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_input.c')
| -rw-r--r-- | net/ipv4/tcp_input.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 113dc5f17d47..53974c7c04fe 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -3291,7 +3291,7 @@ static void tcp_process_tlp_ack(struct sock *sk, u32 ack, int flag) tcp_init_cwnd_reduction(sk, true); tcp_set_ca_state(sk, TCP_CA_CWR); tcp_end_cwnd_reduction(sk); - tcp_set_ca_state(sk, TCP_CA_Open); + tcp_try_keep_open(sk); NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPLOSSPROBERECOVERY); } |