diff options
author | David S. Miller <davem@davemloft.net> | 2008-07-30 02:37:46 -0700 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-07-30 02:44:25 -0700 |
commit | 8d50b53d66a8a6ae41bafbdcabe401467803f33a (patch) | |
tree | 7a23efd740161b5b32d3fd473cf024e1a8931ce1 /net/ipv4/tcp_ipv4.c | |
parent | 38c080ffa9c1b840390832b42ce8621464ab9f97 (diff) | |
download | linux-8d50b53d66a8a6ae41bafbdcabe401467803f33a.tar.gz linux-8d50b53d66a8a6ae41bafbdcabe401467803f33a.tar.bz2 linux-8d50b53d66a8a6ae41bafbdcabe401467803f33a.zip |
pkt_sched: Fix OOPS on ingress qdisc add.
Bug report from Steven Jan Springl:
Issuing the following command causes a kernel oops:
tc qdisc add dev eth0 handle ffff: ingress
The problem mostly stems from all of the special case handling of
ingress qdiscs.
So, to fix this, do the grafting operation the same way we do for TX
qdiscs. Which means that dev_activate() and dev_deactivate() now do
the "qdisc_sleeping <--> qdisc" transitions on dev->rx_queue too.
Future simplifications are possible now, mainly because it is
impossible for dev_queue->{qdisc,qdisc_sleeping} to be NULL. There
are NULL checks all over to handle the ingress qdisc special case
that used to exist before this commit.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_ipv4.c')
0 files changed, 0 insertions, 0 deletions