diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-22 11:21:59 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-07-25 12:42:09 +0100 |
| commit | 59bf6c65a09fff74215517aecffbbdcd67df76e3 (patch) | |
| tree | 9523c70c48008640dafe2c1a42a446b03276efa9 /net/ipv4 | |
| parent | 3e7d18b9dca388940a19cae30bfc1f76dccd8c28 (diff) | |
| download | linux-59bf6c65a09fff74215517aecffbbdcd67df76e3.tar.gz linux-59bf6c65a09fff74215517aecffbbdcd67df76e3.tar.bz2 linux-59bf6c65a09fff74215517aecffbbdcd67df76e3.zip | |
tcp: Fix data-races around sk_pacing_rate.
While reading sysctl_tcp_pacing_(ss|ca)_ratio, they can be changed
concurrently. Thus, we need to add READ_ONCE() to their readers.
Fixes: 43e122b014c9 ("tcp: refine pacing rate determination")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/tcp_input.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index c799f39cb774..dd05238f79f6 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -910,9 +910,9 @@ static void tcp_update_pacing_rate(struct sock *sk) * end of slow start and should slow down. */ if (tcp_snd_cwnd(tp) < tp->snd_ssthresh / 2) - rate *= sock_net(sk)->ipv4.sysctl_tcp_pacing_ss_ratio; + rate *= READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_pacing_ss_ratio); else - rate *= sock_net(sk)->ipv4.sysctl_tcp_pacing_ca_ratio; + rate *= READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_pacing_ca_ratio); rate *= max(tcp_snd_cwnd(tp), tp->packets_out); |