diff options
| author | Willem de Bruijn <willemb@google.com> | 2019-01-15 11:40:02 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-16 15:48:11 -0800 |
| commit | 0f149c9fec3cd720628ecde83bfc6f64c1e7dcb6 (patch) | |
| tree | 5ffd4dacfcc608682b18a9255b393f55e3ca6fdb /net/ipv4 | |
| parent | 1a9352687c19e4937d861ff2c5c6fc45c0a08aff (diff) | |
| download | linux-0f149c9fec3cd720628ecde83bfc6f64c1e7dcb6.tar.gz linux-0f149c9fec3cd720628ecde83bfc6f64c1e7dcb6.tar.bz2 linux-0f149c9fec3cd720628ecde83bfc6f64c1e7dcb6.zip | |
udp: with udp_segment release on error path
Failure __ip_append_data triggers udp_flush_pending_frames, but these
tests happen later. The skb must be freed directly.
Fixes: bec1f6f697362 ("udp: generate gso with UDP_SEGMENT")
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
| -rw-r--r-- | net/ipv4/udp.c | 16 |
1 files changed, 12 insertions, 4 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 3fb0ed5e4789..3d2a81bdc2ab 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -847,15 +847,23 @@ static int udp_send_skb(struct sk_buff *skb, struct flowi4 *fl4, const int hlen = skb_network_header_len(skb) + sizeof(struct udphdr); - if (hlen + cork->gso_size > cork->fragsize) + if (hlen + cork->gso_size > cork->fragsize) { + kfree_skb(skb); return -EINVAL; - if (skb->len > cork->gso_size * UDP_MAX_SEGMENTS) + } + if (skb->len > cork->gso_size * UDP_MAX_SEGMENTS) { + kfree_skb(skb); return -EINVAL; - if (sk->sk_no_check_tx) + } + if (sk->sk_no_check_tx) { + kfree_skb(skb); return -EINVAL; + } if (skb->ip_summed != CHECKSUM_PARTIAL || is_udplite || - dst_xfrm(skb_dst(skb))) + dst_xfrm(skb_dst(skb))) { + kfree_skb(skb); return -EIO; + } skb_shinfo(skb)->gso_size = cork->gso_size; skb_shinfo(skb)->gso_type = SKB_GSO_UDP_L4; |