diff options
| author | Ido Schimmel <idosch@mellanox.com> | 2017-08-03 13:28:21 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-08-03 15:36:00 -0700 |
| commit | c5b12410fa591acb1d48e167b9bd0d2a7a38498d (patch) | |
| tree | ca6ca9c4d7464898cff97fa5a0cb034e0b48e893 /net/ipv6/ip6_fib.c | |
| parent | 61e4d01e16acddadb9723143637a20417fa67ac9 (diff) | |
| download | linux-c5b12410fa591acb1d48e167b9bd0d2a7a38498d.tar.gz linux-c5b12410fa591acb1d48e167b9bd0d2a7a38498d.tar.bz2 linux-c5b12410fa591acb1d48e167b9bd0d2a7a38498d.zip | |
ipv6: fib: Don't assume only nodes hold a reference on routes
The code currently assumes that only FIB nodes can hold a reference on
routes. Therefore, after fib6_purge_rt() has run and the route is no
longer present in any intermediate nodes, it's assumed that its
reference count would be 1 - taken by the node where it's currently
stored.
However, we're going to allow users other than the FIB to take a
reference on a route, so this assumption is no longer valid and the
BUG_ON() needs to be removed.
Note that purging only takes place if the initial reference count is
different than 1. I've left that check intact, as in the majority of
systems (where routes are only referenced by the FIB), it does actually
mean the route is present in intermediate nodes.
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_fib.c')
| -rw-r--r-- | net/ipv6/ip6_fib.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index 719c10480c74..fa27905de92e 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -837,8 +837,6 @@ static void fib6_purge_rt(struct rt6_info *rt, struct fib6_node *fn, } fn = fn->parent; } - /* No more references are possible at this point. */ - BUG_ON(atomic_read(&rt->rt6i_ref) != 1); } } |