diff options
| author | Andrey Konovalov <andreyknvl@google.com> | 2017-02-16 17:22:46 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-02-17 13:36:25 -0500 |
| commit | 5edabca9d4cff7f1f2b68f0bac55ef99d9798ba4 (patch) | |
| tree | 6472d92163649ed669f5814120ecf500765a0548 /net/irda | |
| parent | 785f35775d968e0f45231b754e945fcb3ed6bded (diff) | |
| download | linux-5edabca9d4cff7f1f2b68f0bac55ef99d9798ba4.tar.gz linux-5edabca9d4cff7f1f2b68f0bac55ef99d9798ba4.tar.bz2 linux-5edabca9d4cff7f1f2b68f0bac55ef99d9798ba4.zip | |
dccp: fix freeing skb too early for IPV6_RECVPKTINFO
In the current DCCP implementation an skb for a DCCP_PKT_REQUEST packet
is forcibly freed via __kfree_skb in dccp_rcv_state_process if
dccp_v6_conn_request successfully returns.
However, if IPV6_RECVPKTINFO is set on a socket, the address of the skb
is saved to ireq->pktopts and the ref count for skb is incremented in
dccp_v6_conn_request, so skb is still in use. Nevertheless, it gets freed
in dccp_rcv_state_process.
Fix by calling consume_skb instead of doing goto discard and therefore
calling __kfree_skb.
Similar fixes for TCP:
fb7e2399ec17f1004c0e0ccfd17439f8759ede01 [TCP]: skb is unexpectedly freed.
0aea76d35c9651d55bbaf746e7914e5f9ae5a25d tcp: SYN packets are now
simply consumed
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/irda')
0 files changed, 0 insertions, 0 deletions