diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2021-01-26 11:54:09 +0100 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2021-01-26 12:21:42 +0100 |
| commit | 81f153faacd04c049e5482d6ff33daddc30ed44e (patch) | |
| tree | 11d3dca9d472cd0e21b535a1d148330530c96cff /net/lapb/lapb_timer.c | |
| parent | 054c9939b4800a91475d8d89905827bf9e1ad97a (diff) | |
| download | linux-81f153faacd04c049e5482d6ff33daddc30ed44e.tar.gz linux-81f153faacd04c049e5482d6ff33daddc30ed44e.tar.bz2 linux-81f153faacd04c049e5482d6ff33daddc30ed44e.zip | |
staging: rtl8723bs: fix wireless regulatory API misuse
This code ends up calling wiphy_apply_custom_regulatory(), for which
we document that it should be called before wiphy_register(). This
driver doesn't do that, but calls it from ndo_open() with the RTNL
held, which caused deadlocks.
Since the driver just registers static regdomain data and then the
notifier applies the channel changes if any, there's no reason for
it to call this in ndo_open(), move it earlier to fix the deadlock.
Reported-and-tested-by: Hans de Goede <hdegoede@redhat.com>
Fixes: 51d62f2f2c50 ("cfg80211: Save the regulatory domain with a lock")
Link: https://lore.kernel.org/r/20210126115409.d5fd6f8fe042.Ib5823a6feb2e2aa01ca1a565d2505367f38ad246@changeid
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/lapb/lapb_timer.c')
0 files changed, 0 insertions, 0 deletions