diff options
| author | Andrew Lutomirski <luto@amacapital.net> | 2014-04-16 21:41:34 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-04-22 12:49:39 -0400 |
| commit | 78541c1dc60b65ecfce5a6a096fc260219d6784e (patch) | |
| tree | 45afae9a1e20fbd72426404b1d110aef9cfd6104 /net/packet | |
| parent | b0bda3853266121363a5ad8c786fa82d233538c1 (diff) | |
| download | linux-78541c1dc60b65ecfce5a6a096fc260219d6784e.tar.gz linux-78541c1dc60b65ecfce5a6a096fc260219d6784e.tar.bz2 linux-78541c1dc60b65ecfce5a6a096fc260219d6784e.zip | |
net: Fix ns_capable check in sock_diag_put_filterinfo
The caller needs capabilities on the namespace being queried, not on
their own namespace. This is a security bug, although it likely has
only a minor impact.
Cc: stable@vger.kernel.org
Signed-off-by: Andy Lutomirski <luto@amacapital.net>
Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/packet')
| -rw-r--r-- | net/packet/diag.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/packet/diag.c b/net/packet/diag.c index 533ce4ff108a..435ff99ba8c7 100644 --- a/net/packet/diag.c +++ b/net/packet/diag.c @@ -172,7 +172,7 @@ static int sk_diag_fill(struct sock *sk, struct sk_buff *skb, goto out_nlmsg_trim; if ((req->pdiag_show & PACKET_SHOW_FILTER) && - sock_diag_put_filterinfo(user_ns, sk, skb, PACKET_DIAG_FILTER)) + sock_diag_put_filterinfo(sk, skb, PACKET_DIAG_FILTER)) goto out_nlmsg_trim; return nlmsg_end(skb, nlh); |