diff options
| author | Loic Poulain <loic.poulain@linaro.org> | 2021-03-30 16:11:08 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-03-30 13:48:29 -0700 |
| commit | 8a03dd925786bdc3834d56ccc980bb70668efa35 (patch) | |
| tree | 22f74cffa0d2b3adfef7bf683aa9e6c447c4fd37 /net/qrtr/qrtr.c | |
| parent | 6855e8213e06efcaf7c02a15e12b1ae64b9a7149 (diff) | |
| download | linux-8a03dd925786bdc3834d56ccc980bb70668efa35.tar.gz linux-8a03dd925786bdc3834d56ccc980bb70668efa35.tar.bz2 linux-8a03dd925786bdc3834d56ccc980bb70668efa35.zip | |
net: qrtr: Fix memory leak on qrtr_tx_wait failure
qrtr_tx_wait does not check for radix_tree_insert failure, causing
the 'flow' object to be unreferenced after qrtr_tx_wait return. Fix
that by releasing flow on radix_tree_insert failure.
Fixes: 5fdeb0d372ab ("net: qrtr: Implement outgoing flow control")
Reported-by: syzbot+739016799a89c530b32a@syzkaller.appspotmail.com
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/qrtr/qrtr.c')
| -rw-r--r-- | net/qrtr/qrtr.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index dfc820ee553a..1e4fb568fa84 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -271,7 +271,10 @@ static int qrtr_tx_wait(struct qrtr_node *node, int dest_node, int dest_port, flow = kzalloc(sizeof(*flow), GFP_KERNEL); if (flow) { init_waitqueue_head(&flow->resume_tx); - radix_tree_insert(&node->qrtr_tx_flow, key, flow); + if (radix_tree_insert(&node->qrtr_tx_flow, key, flow)) { + kfree(flow); + flow = NULL; + } } } mutex_unlock(&node->qrtr_tx_lock); |