diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2017-06-10 22:10:34 +0300 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2017-06-13 11:07:51 +0200 |
| commit | 4524667b1e6801a92a4de066788e558b71fe323a (patch) | |
| tree | 22b48d7c298fec668aef523400dbb62ecd04b3c1 /net/rfkill | |
| parent | 6dad28ae197037d8c027f214046c2bbf159bc075 (diff) | |
| download | linux-4524667b1e6801a92a4de066788e558b71fe323a.tar.gz linux-4524667b1e6801a92a4de066788e558b71fe323a.tar.bz2 linux-4524667b1e6801a92a4de066788e558b71fe323a.zip | |
net: rfkill: gpio: Switch to devm_acpi_dev_add_driver_gpios()
Switch to use managed variant of acpi_dev_add_driver_gpios() to simplify
error path and fix potentially wrong assingment if ->probe() fails.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/rfkill')
| -rw-r--r-- | net/rfkill/rfkill-gpio.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c index 76c01cbd56e3..41bd496531d4 100644 --- a/net/rfkill/rfkill-gpio.c +++ b/net/rfkill/rfkill-gpio.c @@ -81,8 +81,7 @@ static int rfkill_gpio_acpi_probe(struct device *dev, rfkill->type = (unsigned)id->driver_data; - return acpi_dev_add_driver_gpios(ACPI_COMPANION(dev), - acpi_rfkill_default_gpios); + return devm_acpi_dev_add_driver_gpios(dev, acpi_rfkill_default_gpios); } static int rfkill_gpio_probe(struct platform_device *pdev) @@ -154,8 +153,6 @@ static int rfkill_gpio_remove(struct platform_device *pdev) rfkill_unregister(rfkill->rfkill_dev); rfkill_destroy(rfkill->rfkill_dev); - acpi_dev_remove_driver_gpios(ACPI_COMPANION(&pdev->dev)); - return 0; } |