diff options
author | Yi Li <yi.li@analog.com> | 2009-04-06 19:00:44 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-04-07 08:31:06 -0700 |
commit | 2cf3683472f043e6748c48228df6d8a35a47ecc2 (patch) | |
tree | 6a7d950cffc88c9a71d314c58dafd0e3cf77a30c /net/rose | |
parent | a963ea83b316b0a3ebf1c7118a6c36b5cd334bb6 (diff) | |
download | linux-2cf3683472f043e6748c48228df6d8a35a47ecc2.tar.gz linux-2cf3683472f043e6748c48228df6d8a35a47ecc2.tar.bz2 linux-2cf3683472f043e6748c48228df6d8a35a47ecc2.zip |
Blackfin SPI Driver: fix bug - spi controller driver does not assert/deassert CS correctly
This bug can be observed when two SPI devices are sharing the spi bus: One
device is set as SPI CS 7, another one is using SPI CS 4.
In spi_bfin5xx.c: cs_active(), cs_deactive() are used to control SPI_FLG
register. From the debug bellow:
cs_active: flag: 0x7f91, chip->flag: 0x7f80, cs: 7
cs_active: flag: 0xef91, chip->flag: 0xef10, cs: 4
When device A (cs_7) activate CS 7, SPI_FLG is set as 0x7f91 (however,
SPI_FLG should be set as 0x7f80, or 0x6f91 if in broadcast mode).
Due to some HW bug (very possibly), if SPI_FLG is set as 0x7f91, SPISSEL7
is asserted, however SPISSEL4 will be asserted too (I can see this using
the scope). This is unreasonable according to HRM.
Signed-off-by: Yi Li <yi.li@analog.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Cc: David Brownell <david-b@pacbell.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/rose')
0 files changed, 0 insertions, 0 deletions