diff options
| author | David Howells <dhowells@redhat.com> | 2022-05-21 09:03:11 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-05-22 21:30:53 +0100 |
| commit | 114af61f88fbe34d641b13922d098ffec4c1be1b (patch) | |
| tree | 451d92bf85d9ef2d19d76896f1b9482c158a4bdd /net/rxrpc/call_event.c | |
| parent | 88e22159750b0d55793302eeed8ee603f5c1a95c (diff) | |
| download | linux-114af61f88fbe34d641b13922d098ffec4c1be1b.tar.gz linux-114af61f88fbe34d641b13922d098ffec4c1be1b.tar.bz2 linux-114af61f88fbe34d641b13922d098ffec4c1be1b.zip | |
rxrpc: Don't try to resend the request if we're receiving the reply
rxrpc has a timer to trigger resending of unacked data packets in a call.
This is not cancelled when a client call switches to the receive phase on
the basis that most calls don't last long enough for it to ever expire.
However, if it *does* expire after we've started to receive the reply, we
shouldn't then go into trying to retransmit or pinging the server to find
out if an ack got lost.
Fix this by skipping the resend code if we're into receiving the reply to a
client call.
Fixes: 17926a79320a ("[AF_RXRPC]: Provide secure RxRPC sockets for use by userspace and kernel both")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/rxrpc/call_event.c')
| -rw-r--r-- | net/rxrpc/call_event.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index 22e05de5d1ca..31761084a76f 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call_event.c @@ -406,7 +406,8 @@ recheck_state: goto recheck_state; } - if (test_and_clear_bit(RXRPC_CALL_EV_RESEND, &call->events)) { + if (test_and_clear_bit(RXRPC_CALL_EV_RESEND, &call->events) && + call->state != RXRPC_CALL_CLIENT_RECV_REPLY) { rxrpc_resend(call, now); goto recheck_state; } |