diff options
| author | David Howells <dhowells@redhat.com> | 2020-06-17 15:46:33 +0100 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2020-06-17 23:01:39 +0100 |
| commit | 02c28dffb13abbaaedece1e4a6493b48ad3f913a (patch) | |
| tree | 5053f6cb96790a33df1c5aa1179fbc675447c611 /net/rxrpc | |
| parent | a2ad7c21ad8cf1ce4ad65e13df1c2a1c29b38ac5 (diff) | |
| download | linux-02c28dffb13abbaaedece1e4a6493b48ad3f913a.tar.gz linux-02c28dffb13abbaaedece1e4a6493b48ad3f913a.tar.bz2 linux-02c28dffb13abbaaedece1e4a6493b48ad3f913a.zip | |
rxrpc: Fix afs large storage transmission performance drop
Commit 2ad6691d988c, which moved the modification of the status annotation
for a packet in the Tx buffer prior to the retransmission moved the state
clearance, but managed to lose the bit that set it to UNACK.
Consequently, if a retransmission occurs, the packet is accidentally
changed to the ACK state (ie. 0) by masking it off, which means that the
packet isn't counted towards the tally of newly-ACK'd packets if it gets
hard-ACK'd. This then prevents the congestion control algorithm from
recovering properly.
Fix by reinstating the change of state to UNACK.
Spotted by the generic/460 xfstest.
Fixes: 2ad6691d988c ("rxrpc: Fix race between incoming ACK parser and retransmitter")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'net/rxrpc')
| -rw-r--r-- | net/rxrpc/call_event.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index aa1c8eee6557..6be2672a65ea 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call_event.c @@ -253,7 +253,7 @@ static void rxrpc_resend(struct rxrpc_call *call, unsigned long now_j) * confuse things */ annotation &= ~RXRPC_TX_ANNO_MASK; - annotation |= RXRPC_TX_ANNO_RESENT; + annotation |= RXRPC_TX_ANNO_UNACK | RXRPC_TX_ANNO_RESENT; call->rxtx_annotations[ix] = annotation; skb = call->rxtx_buffer[ix]; |