diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2017-09-25 13:19:26 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-09-26 21:16:29 -0700 |
| commit | c2cc187e53011c1c4931055984657da9085c763b (patch) | |
| tree | 45ccf097fc85211099c24611e05eee2eece6ee6f /net/sctp/sctp_diag.c | |
| parent | 20c62c797e85b589152970089eaf22a7d88d989a (diff) | |
| download | linux-c2cc187e53011c1c4931055984657da9085c763b.tar.gz linux-c2cc187e53011c1c4931055984657da9085c763b.tar.bz2 linux-c2cc187e53011c1c4931055984657da9085c763b.zip | |
sctp: Fix a big endian bug in sctp_diag_dump()
The sctp_for_each_transport() function takes an pointer to int. The
cb->args[] array holds longs so it's only using the high 32 bits. It
works on little endian system but will break on big endian 64 bit
machines.
Fixes: d25adbeb0cdb ("sctp: fix an use-after-free issue in sctp_sock_dump")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp/sctp_diag.c')
| -rw-r--r-- | net/sctp/sctp_diag.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/sctp/sctp_diag.c b/net/sctp/sctp_diag.c index 22ed01a76b19..a72a7d925d46 100644 --- a/net/sctp/sctp_diag.c +++ b/net/sctp/sctp_diag.c @@ -463,6 +463,7 @@ static void sctp_diag_dump(struct sk_buff *skb, struct netlink_callback *cb, .r = r, .net_admin = netlink_net_capable(cb->skb, CAP_NET_ADMIN), }; + int pos = cb->args[2]; /* eps hashtable dumps * args: @@ -493,7 +494,8 @@ skip: goto done; sctp_for_each_transport(sctp_sock_filter, sctp_sock_dump, - net, (int *)&cb->args[2], &commp); + net, &pos, &commp); + cb->args[2] = pos; done: cb->args[1] = cb->args[4]; |