diff options
| author | Xin Long <lucien.xin@gmail.com> | 2018-04-26 15:21:44 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-04-27 13:34:34 -0400 |
| commit | 6a9a27d5397fc6c52f90c09ddab91e65053584aa (patch) | |
| tree | a72c1b77d12c5a5257b3d21276d84e3873325f86 /net/sctp | |
| parent | 9306b38e42cb266f98bff6f6f4c1c652aa79ba45 (diff) | |
| download | linux-6a9a27d5397fc6c52f90c09ddab91e65053584aa.tar.gz linux-6a9a27d5397fc6c52f90c09ddab91e65053584aa.tar.bz2 linux-6a9a27d5397fc6c52f90c09ddab91e65053584aa.zip | |
sctp: clear the new asoc's stream outcnt in sctp_stream_update
When processing a duplicate cookie-echo chunk, sctp moves the new
temp asoc's stream out/in into the old asoc, and later frees this
new temp asoc.
But now after this move, the new temp asoc's stream->outcnt is not
cleared while stream->out is set to NULL, which would cause a same
crash as the one fixed in Commit 79d0895140e9 ("sctp: fix error
path in sctp_stream_init") when freeing this asoc later.
This fix is to clear this outcnt in sctp_stream_update.
Fixes: f952be79cebd ("sctp: introduce struct sctp_stream_out_ext")
Reported-by: Jianwen Ji <jiji@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/stream.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/sctp/stream.c b/net/sctp/stream.c index f799043abec9..f1f1d1b232ba 100644 --- a/net/sctp/stream.c +++ b/net/sctp/stream.c @@ -240,6 +240,8 @@ void sctp_stream_update(struct sctp_stream *stream, struct sctp_stream *new) new->out = NULL; new->in = NULL; + new->outcnt = 0; + new->incnt = 0; } static int sctp_send_reconf(struct sctp_association *asoc, |