diff options
| author | Daniel Borkmann <dborkman@redhat.com> | 2014-06-30 13:52:09 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-07-02 18:44:07 -0700 |
| commit | eaea2da7286ebc56d557b40ad7e59e715a84e4a0 (patch) | |
| tree | 1507ed91bbbaec02273bf493fa13c2d0a383b6be /net/sctp | |
| parent | 8f61059a96c2a29c1cc5a39dfe23d06ef5b4b065 (diff) | |
| download | linux-eaea2da7286ebc56d557b40ad7e59e715a84e4a0.tar.gz linux-eaea2da7286ebc56d557b40ad7e59e715a84e4a0.tar.bz2 linux-eaea2da7286ebc56d557b40ad7e59e715a84e4a0.zip | |
net: sctp: only warn in proc_sctp_do_alpha_beta if write
Only warn if the value is written to alpha or beta. We don't care
emitting a one-time warning when only reading it.
Reported-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sctp')
| -rw-r--r-- | net/sctp/sysctl.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index 12c7e01c2677..2e9ada10fd84 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -424,8 +424,9 @@ static int proc_sctp_do_alpha_beta(struct ctl_table *ctl, int write, void __user *buffer, size_t *lenp, loff_t *ppos) { - pr_warn_once("Changing rto_alpha or rto_beta may lead to " - "suboptimal rtt/srtt estimations!\n"); + if (write) + pr_warn_once("Changing rto_alpha or rto_beta may lead to " + "suboptimal rtt/srtt estimations!\n"); return proc_dointvec_minmax(ctl, write, buffer, lenp, ppos); } |