diff options
| author | Karsten Graul <kgraul@linux.ibm.com> | 2020-02-17 16:24:50 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-02-17 14:50:24 -0800 |
| commit | 55dd5758175828bd03f4392b4df0d37edd31559d (patch) | |
| tree | bacff0a304f2541c4b7804283432852e1fbd94fb /net/smc/smc_core.c | |
| parent | 790a9a7cce6564fac132ce91ace5c7ab20d9a70f (diff) | |
| download | linux-55dd5758175828bd03f4392b4df0d37edd31559d.tar.gz linux-55dd5758175828bd03f4392b4df0d37edd31559d.tar.bz2 linux-55dd5758175828bd03f4392b4df0d37edd31559d.zip | |
net/smc: improve smc_lgr_cleanup()
smc_lgr_cleanup() is called during termination processing, there is no
need to send a DELETE_LINK at that time. A DELETE_LINK should have been
sent before the termination is initiated, if needed.
And remove the extra call to wake_up(&lnk->wr_reg_wait) because
smc_llc_link_inactive() already calls the related helper function
smc_wr_wakeup_reg_wait().
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc/smc_core.c')
| -rw-r--r-- | net/smc/smc_core.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c index 2249de5379ee..8f3c1fced334 100644 --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -576,11 +576,8 @@ static void smc_lgr_cleanup(struct smc_link_group *lgr) } else { struct smc_link *lnk = &lgr->lnk[SMC_SINGLE_LINK]; - wake_up(&lnk->wr_reg_wait); - if (lnk->state != SMC_LNK_INACTIVE) { - smc_link_send_delete(lnk, false); + if (lnk->state != SMC_LNK_INACTIVE) smc_llc_link_inactive(lnk); - } } } |