diff options
| author | Karsten Graul <kgraul@linux.ibm.com> | 2021-06-02 10:56:25 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-06-03 13:54:49 -0700 |
| commit | f8e0a68babae3f612799178c718ec5358eac41cf (patch) | |
| tree | 64e069387e8e9922e61c5b02d43fac43bb11a978 /net/smc | |
| parent | c356be057432da1720afb5106f4ff102b6a950a7 (diff) | |
| download | linux-f8e0a68babae3f612799178c718ec5358eac41cf.tar.gz linux-f8e0a68babae3f612799178c718ec5358eac41cf.tar.bz2 linux-f8e0a68babae3f612799178c718ec5358eac41cf.zip | |
net/smc: avoid possible duplicate dmb unregistration
smc_lgr_cleanup() calls smcd_unregister_all_dmbs() as part of the link
group termination process. This is a leftover from the times when
smc_lgr_cleanup() scheduled a worker to actually free the link group.
Nowadays smc_lgr_cleanup() directly calls smc_lgr_free() without any
delay so an earlier dmb unregistration is no longer needed.
So remove smcd_unregister_all_dmbs() and the call to it.
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/smc')
| -rw-r--r-- | net/smc/smc_core.c | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/net/smc/smc_core.c b/net/smc/smc_core.c index 0df85a12651e..317bc2c90fab 100644 --- a/net/smc/smc_core.c +++ b/net/smc/smc_core.c @@ -1235,20 +1235,6 @@ static void smc_lgr_free(struct smc_link_group *lgr) kfree(lgr); } -static void smcd_unregister_all_dmbs(struct smc_link_group *lgr) -{ - int i; - - for (i = 0; i < SMC_RMBE_SIZES; i++) { - struct smc_buf_desc *buf_desc; - - list_for_each_entry(buf_desc, &lgr->rmbs[i], list) { - buf_desc->len += sizeof(struct smcd_cdc_msg); - smc_ism_unregister_dmb(lgr->smcd, buf_desc); - } - } -} - static void smc_sk_wake_ups(struct smc_sock *smc) { smc->sk.sk_write_space(&smc->sk); @@ -1285,7 +1271,6 @@ static void smc_lgr_cleanup(struct smc_link_group *lgr) { if (lgr->is_smcd) { smc_ism_signal_shutdown(lgr); - smcd_unregister_all_dmbs(lgr); } else { u32 rsn = lgr->llc_termination_rsn; |