diff options
| author | Jeff Layton <jlayton@redhat.com> | 2012-07-23 15:51:55 -0400 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2012-07-30 18:55:08 -0400 |
| commit | 506026c3ec270e18402f0c9d33fee37482c23861 (patch) | |
| tree | cdfab41737e1493ec17ac433cfefde13618d177e /net/sunrpc | |
| parent | 159e0561e322dd8008fff59e36efff8d2bdd0b0e (diff) | |
| download | linux-506026c3ec270e18402f0c9d33fee37482c23861.tar.gz linux-506026c3ec270e18402f0c9d33fee37482c23861.tar.bz2 linux-506026c3ec270e18402f0c9d33fee37482c23861.zip | |
sunrpc: clarify comments on rpc_make_runnable
rpc_make_runnable is not generally called with the queue lock held, unless
it's waking up a task that has been sitting on a waitqueue. This is safe
when the task has not entered the FSM yet, but the comments don't really
spell this out.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'net/sunrpc')
| -rw-r--r-- | net/sunrpc/sched.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index 994cfea2bad6..ada1e2c33aa4 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -300,8 +300,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_completion_task); /* * Make an RPC task runnable. * - * Note: If the task is ASYNC, this must be called with - * the spinlock held to protect the wait queue operation. + * Note: If the task is ASYNC, and is being made runnable after sitting on an + * rpc_wait_queue, this must be called with the queue spinlock held to protect + * the wait queue operation. */ static void rpc_make_runnable(struct rpc_task *task) { |