diff options
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | 2018-07-27 17:31:35 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-07-27 13:45:15 -0700 |
| commit | a0732548ba03c27fb42da4cf8e1eecc205760f12 (patch) | |
| tree | 3e97b50b21cbf0b1fac00207f9186259a797beab /net/tipc/bcast.c | |
| parent | 04b9ce48ef19e09d8c65eb506b7982e99db212d7 (diff) | |
| download | linux-a0732548ba03c27fb42da4cf8e1eecc205760f12.tar.gz linux-a0732548ba03c27fb42da4cf8e1eecc205760f12.tar.bz2 linux-a0732548ba03c27fb42da4cf8e1eecc205760f12.zip | |
net: tipc: bcast: Replace GFP_ATOMIC with GFP_KERNEL in tipc_bcast_init()
tipc_bcast_init() is never called in atomic context.
It calls kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/bcast.c')
| -rw-r--r-- | net/tipc/bcast.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index f3711176be45..9ee6cfea56dd 100644 --- a/net/tipc/bcast.c +++ b/net/tipc/bcast.c @@ -512,7 +512,7 @@ int tipc_bcast_init(struct net *net) struct tipc_bc_base *bb = NULL; struct tipc_link *l = NULL; - bb = kzalloc(sizeof(*bb), GFP_ATOMIC); + bb = kzalloc(sizeof(*bb), GFP_KERNEL); if (!bb) goto enomem; tn->bcbase = bb; |