diff options
| author | Jon Maloy <jon.maloy@ericsson.com> | 2018-02-26 20:14:04 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-02-27 11:46:03 -0500 |
| commit | 1b22bcad7e397252ecc9a8c471334f70b46820fc (patch) | |
| tree | a89ec297430075d8a6a90ac6aa088d7b15744642 /net/tipc/group.c | |
| parent | 3d18e4f19f37062a0f2cbcf3ac17eaabdde04704 (diff) | |
| download | linux-1b22bcad7e397252ecc9a8c471334f70b46820fc.tar.gz linux-1b22bcad7e397252ecc9a8c471334f70b46820fc.tar.bz2 linux-1b22bcad7e397252ecc9a8c471334f70b46820fc.zip | |
tipc: correct initial value for group congestion flag
In commit 60c253069632 ("tipc: fix race between poll() and
setsockopt()") we introduced a pointer from struct tipc_group to the
'group_is_connected' flag in struct tipc_sock, so that this field can
be checked without dereferencing the group pointer of the latter struct.
The initial value for this flag is correctly set to 'false' when a
group is created, but we miss the case when no group is created at
all, in which case the initial value should be 'true'. This has the
effect that SOCK_RDM/DGRAM sockets sending datagrams never receive
POLLOUT if they request so.
This commit corrects this bug.
Fixes: 60c253069632 ("tipc: fix race between poll() and setsockopt()")
Reported-by: Hoang Le <hoang.h.le@dektek.com.au>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc/group.c')
| -rw-r--r-- | net/tipc/group.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/tipc/group.c b/net/tipc/group.c index 122162a31816..04e516d18054 100644 --- a/net/tipc/group.c +++ b/net/tipc/group.c @@ -189,6 +189,7 @@ struct tipc_group *tipc_group_create(struct net *net, u32 portid, grp->loopback = mreq->flags & TIPC_GROUP_LOOPBACK; grp->events = mreq->flags & TIPC_GROUP_MEMBER_EVTS; grp->open = group_is_open; + *grp->open = false; filter |= global ? TIPC_SUB_CLUSTER_SCOPE : TIPC_SUB_NODE_SCOPE; if (tipc_topsrv_kern_subscr(net, portid, type, 0, ~0, filter, &grp->subid)) |