diff options
| author | Jon Maloy <jon.maloy@ericsson.com> | 2019-04-11 21:56:28 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-11 13:42:35 -0700 |
| commit | 909620ff72c8fcf95b6ef1dca850b24bf016dd27 (patch) | |
| tree | 1005b00adcc986b88c6ed22ef45f73670d43ce16 /net/tipc | |
| parent | 9e35552ae1eafd666e7388a1a94a321665d2f911 (diff) | |
| download | linux-909620ff72c8fcf95b6ef1dca850b24bf016dd27.tar.gz linux-909620ff72c8fcf95b6ef1dca850b24bf016dd27.tar.bz2 linux-909620ff72c8fcf95b6ef1dca850b24bf016dd27.zip | |
tipc: use standard write_lock & unlock functions when creating node
In the function tipc_node_create() we protect the peer capability field
by using the node rw_lock. However, we access the lock directly instead
of using the dedicated functions for this, as we do everywhere else in
node.c. This cosmetic spot is fixed here.
Fixes: 40999f11ce67 ("tipc: make link capability update thread safe")
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/tipc')
| -rw-r--r-- | net/tipc/node.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/tipc/node.c b/net/tipc/node.c index 3469b5d4ed32..7478e2d4ec02 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -375,14 +375,15 @@ static struct tipc_node *tipc_node_create(struct net *net, u32 addr, if (n->capabilities == capabilities) goto exit; /* Same node may come back with new capabilities */ - write_lock_bh(&n->lock); + tipc_node_write_lock(n); n->capabilities = capabilities; for (bearer_id = 0; bearer_id < MAX_BEARERS; bearer_id++) { l = n->links[bearer_id].link; if (l) tipc_link_update_caps(l, capabilities); } - write_unlock_bh(&n->lock); + tipc_node_write_unlock_fast(n); + /* Calculate cluster capabilities */ tn->capabilities = TIPC_NODE_CAPABILITIES; list_for_each_entry_rcu(temp_node, &tn->node_list, list) { |