diff options
| author | Mathias Krause <minipli@googlemail.com> | 2017-08-26 17:08:58 +0200 |
|---|---|---|
| committer | Steffen Klassert <steffen.klassert@secunet.com> | 2017-08-28 10:58:02 +0200 |
| commit | 50329c8a340c9dea60d837645fcf13fc36bfb84d (patch) | |
| tree | c54e85cb149711b653ef3953d6dbe18e4d444615 /net/xfrm | |
| parent | 5fe0d4bd8f86d19f7f24c1ae5a9b6e6a5a52e51a (diff) | |
| download | linux-50329c8a340c9dea60d837645fcf13fc36bfb84d.tar.gz linux-50329c8a340c9dea60d837645fcf13fc36bfb84d.tar.bz2 linux-50329c8a340c9dea60d837645fcf13fc36bfb84d.zip | |
xfrm_user: fix info leak in xfrm_notify_sa()
The memory reserved to dump the ID of the xfrm state includes a padding
byte in struct xfrm_usersa_id added by the compiler for alignment. To
prevent the heap info leak, memset(0) the whole struct before filling
it.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Fixes: 0603eac0d6b7 ("[IPSEC]: Add XFRMA_SA/XFRMA_POLICY for delete notification")
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Diffstat (limited to 'net/xfrm')
| -rw-r--r-- | net/xfrm/xfrm_user.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 3259555ae7d7..c33516ef52f2 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -2715,6 +2715,7 @@ static int xfrm_notify_sa(struct xfrm_state *x, const struct km_event *c) struct nlattr *attr; id = nlmsg_data(nlh); + memset(id, 0, sizeof(*id)); memcpy(&id->daddr, &x->id.daddr, sizeof(id->daddr)); id->spi = x->id.spi; id->family = x->props.family; |