diff options
| author | Antonio Quartulli <antonio@meshcoding.com> | 2014-12-20 13:48:57 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-12-23 23:13:37 -0500 |
| commit | 0d1644919578db525b9a7b6c8197ce02adbfce26 (patch) | |
| tree | 98dd759ca950e3d8220ff7504baba8c4bec7b7da /net | |
| parent | 0402e444cd199389b7fe47be68a67b817e09e097 (diff) | |
| download | linux-0d1644919578db525b9a7b6c8197ce02adbfce26.tar.gz linux-0d1644919578db525b9a7b6c8197ce02adbfce26.tar.bz2 linux-0d1644919578db525b9a7b6c8197ce02adbfce26.zip | |
batman-adv: avoid NULL dereferences and fix if check
Gateway having bandwidth_down equal to zero are not accepted
at all and so never added to the Gateway list.
For this reason checking the bandwidth_down member in
batadv_gw_out_of_range() is useless.
This is probably a copy/paste error and this check was supposed
to be "!gw_node" only. Moreover, the way the check is written
now may also lead to a NULL dereference.
Fix this by rewriting the if-condition properly.
Introduced by 414254e342a0d58144de40c3da777521ebaeeb07
("batman-adv: tvlv - gateway download/upload bandwidth container")
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/batman-adv/gateway_client.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/gateway_client.c b/net/batman-adv/gateway_client.c index 90cff585b37d..e0bcf9e84273 100644 --- a/net/batman-adv/gateway_client.c +++ b/net/batman-adv/gateway_client.c @@ -810,7 +810,7 @@ bool batadv_gw_out_of_range(struct batadv_priv *bat_priv, goto out; gw_node = batadv_gw_node_get(bat_priv, orig_dst_node); - if (!gw_node->bandwidth_down == 0) + if (!gw_node) goto out; switch (atomic_read(&bat_priv->gw_mode)) { |