diff options
| author | Eric Dumazet <edumazet@google.com> | 2014-02-25 04:31:03 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-02-26 15:19:47 -0500 |
| commit | 9a9bfd032f0207dd6e63c84b7676b58f160af04b (patch) | |
| tree | 69f714ca5c2b2260bbcad206464b0bdba7be9a97 /net | |
| parent | a4572e0c23266d01949a1c134475e3bfa7f788e1 (diff) | |
| download | linux-9a9bfd032f0207dd6e63c84b7676b58f160af04b.tar.gz linux-9a9bfd032f0207dd6e63c84b7676b58f160af04b.tar.bz2 linux-9a9bfd032f0207dd6e63c84b7676b58f160af04b.zip | |
net: tcp: use NET_INC_STATS()
While LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES can only be incremented
in tcp_transmit_skb() from softirq (incoming message or timer
activation), it is better to use NET_INC_STATS() instead of
NET_INC_STATS_BH() as tcp_transmit_skb() can be called from process
context.
This will avoid copy/paste confusion when/if we want to add
other SNMP counters in tcp_transmit_skb()
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/tcp_output.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 09805817627b..d718482fd11c 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -864,8 +864,8 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it, if (unlikely(skb->fclone == SKB_FCLONE_ORIG && fclone->fclone == SKB_FCLONE_CLONE)) - NET_INC_STATS_BH(sock_net(sk), - LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES); + NET_INC_STATS(sock_net(sk), + LINUX_MIB_TCPSPURIOUS_RTX_HOSTQUEUES); if (unlikely(skb_cloned(skb))) skb = pskb_copy(skb, gfp_mask); |