summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJulien Brunel <brunel@diku.dk>2008-08-13 02:40:48 -0700
committerDavid S. Miller <davem@davemloft.net>2008-08-13 02:40:48 -0700
commit34093d055e09d1bb549efc11c8d448373437bbe4 (patch)
treec2197fb6b066087a8a4ae707e32317d33574768f /net
parent317900cb010f4aca0e3cb14a02d0ddcc44ddafa7 (diff)
downloadlinux-34093d055e09d1bb549efc11c8d448373437bbe4.tar.gz
linux-34093d055e09d1bb549efc11c8d448373437bbe4.tar.bz2
linux-34093d055e09d1bb549efc11c8d448373437bbe4.zip
net/rxrpc: Use an IS_ERR test rather than a NULL test
In case of error, the function rxrpc_get_transport returns an ERR pointer, but never returns a NULL pointer. So after a call to this function, a NULL test should be replaced by an IS_ERR test. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @correct_null_test@ expression x,E; statement S1, S2; @@ x = rxrpc_get_transport(...) <... when != x = E if ( ( - x@p2 != NULL + ! IS_ERR ( x ) | - x@p2 == NULL + IS_ERR( x ) ) ) S1 else S2 ...> ? x = E; // </smpl> Signed-off-by: Julien Brunel <brunel@diku.dk> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/rxrpc/ar-accept.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/rxrpc/ar-accept.c b/net/rxrpc/ar-accept.c
index bdfb77417794..77228f28fa36 100644
--- a/net/rxrpc/ar-accept.c
+++ b/net/rxrpc/ar-accept.c
@@ -100,7 +100,7 @@ static int rxrpc_accept_incoming_call(struct rxrpc_local *local,
trans = rxrpc_get_transport(local, peer, GFP_NOIO);
rxrpc_put_peer(peer);
- if (!trans) {
+ if (IS_ERR(trans)) {
_debug("no trans");
ret = -EBUSY;
goto error;