diff options
| author | Paul Gortmaker <paul.gortmaker@windriver.com> | 2012-01-19 15:40:06 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-01-22 15:08:44 -0500 |
| commit | bf0813bd282f6ded0a5efca3db238287f7a3dbe8 (patch) | |
| tree | 7c2cf691a713abb91fa4e452a5d4dad82bb4810a /net | |
| parent | 974c12360dfe6ab01201fe9e708e7755c413f8b6 (diff) | |
| download | linux-bf0813bd282f6ded0a5efca3db238287f7a3dbe8.tar.gz linux-bf0813bd282f6ded0a5efca3db238287f7a3dbe8.tar.bz2 linux-bf0813bd282f6ded0a5efca3db238287f7a3dbe8.zip | |
pktgen: Fix unsigned function that is returning negative vals
Every call to num_args() immediately checks the return value for
less than zero, as it will return -EFAULT for a failed get_user()
call. So it makes no sense for the function to be declared as an
unsigned long.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/pktgen.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 65f80c7b1656..4d8ce93cd503 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -767,8 +767,8 @@ done: return i; } -static unsigned long num_arg(const char __user * user_buffer, - unsigned long maxlen, unsigned long *num) +static long num_arg(const char __user *user_buffer, unsigned long maxlen, + unsigned long *num) { int i; *num = 0; |