summaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJosh Hunt <johunt@akamai.com>2015-03-19 19:19:30 -0400
committerDavid S. Miller <davem@davemloft.net>2015-03-20 13:18:52 -0400
commitd22e1537181188e5dc8cbc51451832625035bdc2 (patch)
treeb207b5f9b1562e4f1c6f5a97cb09cabb88ca9fea /net
parent73ba57bfae4a1914f6a6dac71e3168dd900e00af (diff)
downloadlinux-d22e1537181188e5dc8cbc51451832625035bdc2.tar.gz
linux-d22e1537181188e5dc8cbc51451832625035bdc2.tar.bz2
linux-d22e1537181188e5dc8cbc51451832625035bdc2.zip
tcp: fix tcp fin memory accounting
tcp_send_fin() does not account for the memory it allocates properly, so sk_forward_alloc can be negative in cases where we've sent a FIN: ss example output (ss -amn | grep -B1 f4294): tcp FIN-WAIT-1 0 1 192.168.0.1:45520 192.0.2.1:8080 skmem:(r0,rb87380,t0,tb87380,f4294966016,w1280,o0,bl0) Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/ipv4/tcp_output.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index a2a796c5536b..1db253e36045 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2773,15 +2773,11 @@ void tcp_send_fin(struct sock *sk)
} else {
/* Socket is locked, keep trying until memory is available. */
for (;;) {
- skb = alloc_skb_fclone(MAX_TCP_HEADER,
- sk->sk_allocation);
+ skb = sk_stream_alloc_skb(sk, 0, sk->sk_allocation);
if (skb)
break;
yield();
}
-
- /* Reserve space for headers and prepare control bits. */
- skb_reserve(skb, MAX_TCP_HEADER);
/* FIN eats a sequence byte, write_seq advanced by tcp_queue_skb(). */
tcp_init_nondata_skb(skb, tp->write_seq,
TCPHDR_ACK | TCPHDR_FIN);