diff options
| author | Eric Lapuyade <eric.lapuyade@intel.com> | 2012-05-03 14:53:20 +0200 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2012-07-09 16:42:05 -0400 |
| commit | d3b404453192aa195ccfb2f0d946f880b16f8b1f (patch) | |
| tree | ac14a4d471b8593fe500c9785c370e67b3bfef29 /net | |
| parent | a9a741a7e2e6337ae5c030e78827c233c08902a7 (diff) | |
| download | linux-d3b404453192aa195ccfb2f0d946f880b16f8b1f.tar.gz linux-d3b404453192aa195ccfb2f0d946f880b16f8b1f.tar.bz2 linux-d3b404453192aa195ccfb2f0d946f880b16f8b1f.zip | |
NFC: Removed addressed shdlc TODOs
The questions asked in the comments have been answered and addressed.
Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/nfc/hci/shdlc.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/net/nfc/hci/shdlc.c b/net/nfc/hci/shdlc.c index d7c74d152a72..18d1536df5f6 100644 --- a/net/nfc/hci/shdlc.c +++ b/net/nfc/hci/shdlc.c @@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r) shdlc->state = SHDLC_CONNECTED; } else { shdlc->state = SHDLC_DISCONNECTED; - - /* - * TODO: Could it be possible that there are pending - * executing commands that are waiting for connect to complete - * before they can be carried? As connect is a blocking - * operation, it would require that the userspace process can - * send commands on the same device from a second thread before - * the device is up. I don't think that is possible, is it? - */ } shdlc->connect_result = r; @@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc) { pr_debug("\n"); - /* TODO: Check that this cannot be called while still in use */ - nfc_hci_unregister_device(shdlc->hdev); nfc_hci_free_device(shdlc->hdev); |