diff options
| author | David Miller <davem@davemloft.net> | 2018-06-11 18:00:13 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-06-11 20:00:56 -0700 |
| commit | 6892286e9c09925780fe2cb6db3585b56b71fe8e (patch) | |
| tree | d000676838c8e6e773f757619cf47dfa23397792 /net | |
| parent | 0ca69d1399eefd481f926bb5f271ddc2da38d4f4 (diff) | |
| download | linux-6892286e9c09925780fe2cb6db3585b56b71fe8e.tar.gz linux-6892286e9c09925780fe2cb6db3585b56b71fe8e.tar.bz2 linux-6892286e9c09925780fe2cb6db3585b56b71fe8e.zip | |
tcp: Do not reload skb pointer after skb_gro_receive().
This is not necessary. skb_gro_receive() will never change what
'head' points to.
In it's original implementation (see commit 71d93b39e52e ("net: Add
skb_gro_receive")), it did:
====================
+ *head = nskb;
+ nskb->next = p->next;
+ p->next = NULL;
====================
This sequence was removed in commit 58025e46ea2d ("net: gro: remove
obsolete code from skb_gro_receive()")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/tcp_offload.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/net/ipv4/tcp_offload.c b/net/ipv4/tcp_offload.c index 4d58e2ce0b5b..8cc7c3487330 100644 --- a/net/ipv4/tcp_offload.c +++ b/net/ipv4/tcp_offload.c @@ -268,8 +268,6 @@ found: goto out_check_final; } - p = *head; - th2 = tcp_hdr(p); tcp_flag_word(th2) |= flags & (TCP_FLAG_FIN | TCP_FLAG_PSH); out_check_final: |