diff options
| author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-01-22 14:47:19 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-22 17:24:18 -0800 |
| commit | 1518039f6b5ac794313c24c76f85cead0cd60f6c (patch) | |
| tree | 1ade65e4d0b8b45670a7de1b0d045b6e7b3c509b /net | |
| parent | cb73ee40b1b381eaf3749e6dbeed567bb38e5258 (diff) | |
| download | linux-1518039f6b5ac794313c24c76f85cead0cd60f6c.tar.gz linux-1518039f6b5ac794313c24c76f85cead0cd60f6c.tar.bz2 linux-1518039f6b5ac794313c24c76f85cead0cd60f6c.zip | |
net/ipv6: don't return positive numbers when nothing was dumped
in6_dump_addrs() returns a positive 1 if there was nothing to dump.
This return value can not be passed as return from inet6_dump_addr()
as is, because it will confuse rtnetlink, resulting in NLMSG_DONE
never getting set:
$ ip addr list dev lo
EOF on netlink
Dump terminated
v2: flip condition to avoid a new goto (DaveA)
Fixes: 7c1e8a3817c5 ("netlink: fixup regression in RTM_GETADDR")
Reported-by: Brendan Galloway <brendan.galloway@netronome.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Tested-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/addrconf.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 93d5ad2b1a69..0c9e20ac01ab 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -5120,6 +5120,8 @@ static int inet6_dump_addr(struct sk_buff *skb, struct netlink_callback *cb, if (idev) { err = in6_dump_addrs(idev, skb, cb, s_ip_idx, &fillargs); + if (err > 0) + err = 0; } goto put_tgt_net; } |