diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2014-10-21 11:28:12 +0300 |
|---|---|---|
| committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2014-10-22 14:12:50 +0200 |
| commit | 0f9f5e1b83abd2b37c67658e02a6fc9001831fa5 (patch) | |
| tree | 52e37b5829240e5d18b196831f25f338db3745cf /net | |
| parent | e37ad9fd636071e45368d1d9cc3b7b421281ce7f (diff) | |
| download | linux-0f9f5e1b83abd2b37c67658e02a6fc9001831fa5.tar.gz linux-0f9f5e1b83abd2b37c67658e02a6fc9001831fa5.tar.bz2 linux-0f9f5e1b83abd2b37c67658e02a6fc9001831fa5.zip | |
netfilter: ipset: off by one in ip_set_nfnl_get_byindex()
The ->ip_set_list[] array is initialized in ip_set_net_init() and it
has ->ip_set_max elements so this check should be >= instead of >
otherwise we are off by one.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/netfilter/ipset/ip_set_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index 912e5a05b79d..86f9d76b1464 100644 --- a/net/netfilter/ipset/ip_set_core.c +++ b/net/netfilter/ipset/ip_set_core.c @@ -659,7 +659,7 @@ ip_set_nfnl_get_byindex(struct net *net, ip_set_id_t index) struct ip_set *set; struct ip_set_net *inst = ip_set_pernet(net); - if (index > inst->ip_set_max) + if (index >= inst->ip_set_max) return IPSET_INVALID_ID; nfnl_lock(NFNL_SUBSYS_IPSET); |