diff options
| author | Lorenzo Colitti <lorenzo@google.com> | 2016-12-23 00:33:57 +0900 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-12-22 11:15:10 -0500 |
| commit | 7d99569460eae28b187d574aec930a4cf8b90441 (patch) | |
| tree | 99477f48a607f4825a46f987a5f26c40b3041444 /net | |
| parent | 551cde192343a10c8fbd57c4cc8f0c4b6cd307e4 (diff) | |
| download | linux-7d99569460eae28b187d574aec930a4cf8b90441.tar.gz linux-7d99569460eae28b187d574aec930a4cf8b90441.tar.bz2 linux-7d99569460eae28b187d574aec930a4cf8b90441.zip | |
net: ipv4: Don't crash if passing a null sk to ip_do_redirect.
Commit e2d118a1cb5e ("net: inet: Support UID-based routing in IP
protocols.") made ip_do_redirect call sock_net(sk) to determine
the network namespace of the passed-in socket. This crashes if sk
is NULL.
Fix this by getting the network namespace from the skb instead.
Fixes: e2d118a1cb5e ("net: inet: Support UID-based routing in IP protocols.")
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/route.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv4/route.c b/net/ipv4/route.c index fa5c037227cb..9eabf490133a 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -798,6 +798,7 @@ static void ip_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_buf struct rtable *rt; struct flowi4 fl4; const struct iphdr *iph = (const struct iphdr *) skb->data; + struct net *net = dev_net(skb->dev); int oif = skb->dev->ifindex; u8 tos = RT_TOS(iph->tos); u8 prot = iph->protocol; @@ -805,7 +806,7 @@ static void ip_do_redirect(struct dst_entry *dst, struct sock *sk, struct sk_buf rt = (struct rtable *) dst; - __build_flow_key(sock_net(sk), &fl4, sk, iph, oif, tos, prot, mark, 0); + __build_flow_key(net, &fl4, sk, iph, oif, tos, prot, mark, 0); __ip_do_redirect(rt, skb, &fl4, true); } |