diff options
| author | Bernd Edlinger <bernd.edlinger@hotmail.de> | 2017-10-21 06:51:30 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-10-22 03:24:43 +0100 |
| commit | 8d5f4b07174976c55a5f5d6967777373c6826944 (patch) | |
| tree | 469d91c7c5ee7bf8343f193c6abf152d4a75de73 /net | |
| parent | 864e2a1f8aac05effac6063ce316b480facb46ff (diff) | |
| download | linux-8d5f4b07174976c55a5f5d6967777373c6826944.tar.gz linux-8d5f4b07174976c55a5f5d6967777373c6826944.tar.bz2 linux-8d5f4b07174976c55a5f5d6967777373c6826944.zip | |
stmmac: Don't access tx_q->dirty_tx before netif_tx_lock
This is the possible reason for different hard to reproduce
problems on my ARMv7-SMP test system.
The symptoms are in recent kernels imprecise external aborts,
and in older kernels various kinds of network stalls and
unexpected page allocation failures.
My testing indicates that the trouble started between v4.5 and v4.6
and prevails up to v4.14.
Using the dirty_tx before acquiring the spin lock is clearly
wrong and was first introduced with v4.6.
Fixes: e3ad57c96715 ("stmmac: review RX/TX ring management")
Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions